s2n: upgrade 1.3.50 -> 1.3.51 some unittests fail

[thomas-roos]

Problem:

after upgrade some unit tests fail:

{'s2n': ['s2n_unittest:./s2n_blob_test',
's2n_unittest:./s2n_client_key_share_extension_pq_test',
's2n_unittest:./s2n_client_session_ticket_extension_test',
's2n_unittest:./s2n_early_data_test',
's2n_unittest:./s2n_ecc_evp_test',
's2n_unittest:./s2n_extensions_server_key_share_select_test',
's2n_unittest:./s2n_kem_test',
's2n_unittest:./s2n_pq_kem_test',
's2n_unittest:./s2n_psk_offered_test',
's2n_unittest:./s2n_psk_test',
's2n_unittest:./s2n_quic_support_io_test',
's2n_unittest:./s2n_quic_support_test',
's2n_unittest:./s2n_resume_test',
's2n_unittest:./s2n_stuffer_test',
's2n_unittest:./s2n_tls13_handshake_early_data_test',
's2n_unittest:./s2n_tls13_hybrid_shared_secret_test',
's2n_unittest:_./s2n_tls13_server_cert_test']}

unit_test_log.txt

[dougch]

Thanks for the issue, can you provide the cmake banner and/or the platform, compiler, libcrypto used so we can try to reproduce this?

[thomas-roos]

This can be easy reproduced with yocto + meta-aws.
gcc version x86_64-poky-linux-gcc (GCC) 13.2.0
openssl 3.1.3

As you see it's the same issue on all of those failed tests
Error Message: 's2n not initialized'
So may solution is easy?

s2n_compile.log
log.do_testimage.log

[toidiu]

Hi @thomas-roos unfortunately we dont test/support the yocto platform so its non-trivial for us to repro this issue. However its curious why the build started failing since our CI didnt catch the regression. I am wondering If you might be able to help test and provide the commit which broke your build.

I am also curious if there is a Github CI action (PRs welcome :D) which we can add to catch this regression at development time? Without this there is no guarantee to prevent breakage in the future also.

Here is are the commits which were added between the two releases.

[thomas-roos]

Hi,
I can try this, but might will take time since I'm on PTO soon...
Cheers, Thomas