Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoPublishAlias is not triggered for timeout changes #2418

Closed
tdmalone opened this issue Jun 20, 2022 · 3 comments
Closed

AutoPublishAlias is not triggered for timeout changes #2418

tdmalone opened this issue Jun 20, 2022 · 3 comments

Comments

@tdmalone
Copy link

tdmalone commented Jun 20, 2022

Description:

Changing the timeout for a function does not cause a new version to be published when using AutoPublishAlias.

Steps to reproduce:

  1. Deploy a SAM template with an AWS::Serverless::Function resource, with AutoPublishAlias set, and specifying any valid value for Timeout.
  2. Change the Timeout value to another valid value, and redeploy.

Observed result:

The Timeout value changes on $LATEST, but a new version is not created.

Expected result:

A new version to be created, with the updated configuration.

See also

Similar to #1305, in particular note #1305 (comment) which implies that relevant properties could be added to the hash used to determine if a new version is needed.

@tdmalone tdmalone added stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. type/bug labels Jun 20, 2022
@mildaniel
Copy link
Contributor

Hey @tdmalone, thanks for bringing this up. Since resolving this would be considered a backwards incompatible change, we are considering this as a candidate for when we version bump SAM.

@torresxb1 torresxb1 removed the stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. label Jun 28, 2022
@hoffa
Copy link
Contributor

hoffa commented Dec 14, 2022

There's been a few similar requests (e.g. #413). We can't update the most straightforward way as it would be a backward incompatible change (would cause many redeployments).

We could however consider an opt-in approach. Something like this (just rough idea):

MyFunction:
  Type: AWS::Serverless::Function
  Properties:
    Timeout: 10
    AutoPublishAlias: live
    AutoPublishAdditionalProperties:
      - Timeout
    ...

@hoffa
Copy link
Contributor

hoffa commented Dec 14, 2022

I'll close this in favor of #413.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants