Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on supported version of go fails #23

Open
skwashd opened this issue Nov 10, 2021 · 3 comments
Open

Build on supported version of go fails #23

skwashd opened this issue Nov 10, 2021 · 3 comments

Comments

@skwashd
Copy link

skwashd commented Nov 10, 2021

It isn't possible to build the binary with go 1.16+. Support for 1.15 was dropped back in August. Right now it's not possible to build the package with a supported version of go. The go vet step in checkstyle.sh fails because the project doesn't use modules (see #11 for a fix for that). Then doing the build it fails with multiple go.mod file not found in current directory or any parent directory; see 'go help modules' errors.

Please apply #11 so this project can be built with modern go.

@skwashd skwashd changed the title Build on supported version of go Build on supported version of go fails Nov 10, 2021
@shaib
Copy link

shaib commented Dec 5, 2021

I tried export GO111MODULE=auto as a "lightweight alternative" to #11 (which is a major change in the package structure, with >5000 file changes).
This still fails:

# _/home/slate/session-manager-plugin/src/sessionmanagerplugin/session/portsession
src/sessionmanagerplugin/session/portsession/basicportforwarding.go:169:2: misuse of unbuffered os.Signal channel as argument to signal.Notify
src/sessionmanagerplugin/session/portsession/muxportforwarding.go:182:2: misuse of unbuffered os.Signal channel as argument to signal.Notify
make: *** [makefile:18: checkstyle] Error 2

@rinarakaki
Copy link

Any updates?

@vinoddampuru-tw
Copy link

Any updated on this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants