Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Instructions wrt VERSION #76

Open
calebcase opened this issue Jul 3, 2023 · 1 comment
Open

Build Instructions wrt VERSION #76

calebcase opened this issue Jul 3, 2023 · 1 comment

Comments

@calebcase
Copy link

The README.md instructions seem to be incomplete. Following those instructions results in a binary that reports its version as 1.2.0.0. This is true even if you checkout a (recent) specific version tag and build from that.

This wouldn't be an issue, but the version number it reports is load bearing. If the version is wrong, then this issue regarding timeouts re-emerges aws/aws-sdk-go#4691. Editing the VERSION file directly and rerunning the build results in a binary without the issue.

I wasn't able to find where in the build tooling this VERSION file was intended to be updated to the correct version. I used printf 1.2.463.0 > VERSION to update the file to the latest release tag. It would be very helpful to have some instructions in the README.md on the proper way to update this file as part of the local build instructions.
@toralf-hlag
Copy link

still a problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@calebcase @toralf-hlag