Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support renamed errors in aws-json-1.1 protocol #480

Open
2 tasks
everett1992 opened this issue Jan 5, 2023 · 1 comment
Open
2 tasks

Support renamed errors in aws-json-1.1 protocol #480

everett1992 opened this issue Jan 5, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@everett1992
Copy link

Describe the feature

Smithy recently allowed renaming error shapes but added a validator to prevent renamed errors with aws protocols.

Most aws protocols only use shape name in error serialization, which is why error renames were originally banned. However, aws json 1.0 uses qualified shape id and can support renamed errors.

The protocol should match errors based on the original (not renamed) fully qualified shape id.

Once all smithy sdk's (rust, js, go, kotlin) confirm that aws json 1.0 supports renamed errors smithy can remove the protocol from the validator and allow renames.

smithy-lang/smithy#1545

Use Case

I have smithy a smithy model with shapes with conflicting names, tho the qualified shape id is unique. I'd like to use aws json 1.0 protocol, which could support renamed error shapes, but the validator throws an error.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS Go SDK V2 Module Versions Used

N/A

Go version used

N/A

@everett1992 everett1992 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 5, 2023
@RanVaknin RanVaknin self-assigned this Jan 5, 2023
@RanVaknin RanVaknin removed the needs-triage This issue or PR still needs to be triaged. label Mar 9, 2023
@RanVaknin
Copy link
Contributor

Hi @everett1992 we will add it to the backlog. Currently there is no timeline for implementation.

Thank you.
Ran~

@RanVaknin RanVaknin removed their assignment Mar 9, 2023
@lucix-aws lucix-aws transferred this issue from aws/aws-sdk-go-v2 Nov 28, 2023
@lucix-aws lucix-aws added enhancement New feature or request and removed feature-request A feature should be added or improved. labels Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants