Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open the GitHub repository by Studio Lab link #11

Closed
icoxfog417 opened this issue Dec 4, 2021 · 4 comments
Closed

Open the GitHub repository by Studio Lab link #11

icoxfog417 opened this issue Dec 4, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@icoxfog417
Copy link
Contributor

icoxfog417 commented Dec 4, 2021

Is your feature request related to a problem? Please describe.

When I study machine learning from the GitHub repository that contains multiple .ipynb files, I have to open a file one by one because the Studio Lab link only allows opening the individual files.

Describe the solution you'd like
image

Describe alternatives you've considered
To put the Studio Lab button to each Jupyter notebook. But it is redundant work for the repository maintainer.

Additional context
This feature will be necessary to add Studio Lab to Jupyter Book, which is used to write the various machine learning books. (I tried to add Studio Lab link to Jupyter Book and found the discussion that suggests the necessity of the above feature..)

@icoxfog417 icoxfog417 added the enhancement New feature or request label Dec 4, 2021
@samx18
Copy link
Contributor

samx18 commented Dec 4, 2021

Thanks for checking out Studio lab. How about cloning the repository from Studio lab instead? Does that help? Studio Lab supports git integrations and cloning. Perhaps include instructions in the README of your repo to clone it via Studio lab?

@icoxfog417
Copy link
Contributor Author

icoxfog417 commented Dec 5, 2021

Dear @samx18 , thank you for your reply!

I confirmed that I can select copy .ipynb or clone the entire repository on the popup window.
When selecting the clone, git clone runs. It's sufficient for me and the Studio Lab users.

  1. Click "Open in SageMaker" Button on GitHub repository.
  2. Click "Start runtime"
  3. Click "Copy to Project" on the notebook.
  4. Popup "Copy from GitHub?"
  5. Click "Clone Entire Repo"
  6. (git clone run on Studio Lab)

When I want the users to clone the entire repository, I want to point out README.md in the GitHub repository.
From the document, I assume that the Studio Lab link allows a markdown file but when opening the README.md causes the error.

For example, the following link that opens README.md of this repository causes the error.
https://studiolab.sagemaker.aws/import/github/aws/studio-lab-examples/blob/main/README.md

image

If I make some mistake, please let me know!

@adalseno
Copy link

adalseno commented Dec 6, 2021

I don't know if this helps but if you clone the repo locally

(studiolab) studio-lab-user@default:~/sagemaker-studiolab-notebooks$ mkdir tmp_project
(studiolab) studio-lab-user@default:~/sagemaker-studiolab-notebooks$ cd tmp_project/
(studiolab) studio-lab-user@default:~/sagemaker-studiolab-notebooks/tmp_project$ git clone https://github.com/tirthajyoti/Machine-Learning-with-Python.git

then you can open the file using the markdown preview like this:
Schermata 2021-12-06 alle 20 05 55

And it will open the markdown:
Schermata 2021-12-06 alle 20 06 06

@EmilyWebber
Copy link
Contributor

EmilyWebber commented Dec 6, 2021

Yes - you can both clone the repo locally and use the UI through the button to clone the entire repository. The instructions were incorrect - currently only ipython notebooks are supported to open via the button, and markdown files are not. If you like, you can open an issue in the feature request format to request this. I've also updated the instructions.

https://github.com/aws/studio-lab-examples/blob/main/.github/ISSUE_TEMPLATE/feature-request-for-sagemaker-studio-lab.md

Thanks for trying SM Studio Lab!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants