Skip to content

Release supported version using AWS SDK v2. #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cnauroth opened this issue Mar 31, 2020 · 10 comments · Fixed by #86 or #87
Closed

Release supported version using AWS SDK v2. #48

cnauroth opened this issue Mar 31, 2020 · 10 comments · Fixed by #86 or #87
Assignees

Comments

@cnauroth
Copy link

This pull request integrated with AWS SDK v2 on the master branch:

#19

However, it is described as "preliminary". From what I can tell, there is not yet a formally supported release with AWS SDK v2 support.

I'd like to request completion of this feature and distribution of a new Maven release. Right now, projects using dynamodb-lock-client are forced into a transitive dependency on AWS SDK v1, even if their codebase otherwise has migrated to AWS SDK v2.

@cnauroth
Copy link
Author

FWIW, I built the current master branch code and linked one of my applications with it. Everything worked fine, and all of my application's tests passed. That's a good sign that the core functionality works, though the original MR mentions a potential feature gap around metrics.

@reibitto
Copy link

I was looking for this too. If it's still not quite production-ready, perhaps a release candidate would be an alright solution in the meantime? That would allow people to test it in real applications easier and give feedback if any bugs are found.

@tbfky
Copy link

tbfky commented Jan 4, 2021

Any update on this?

@aleksanderEE
Copy link

@amcp any chance that will happen?

@martin-nginio
Copy link

Hi @khanshariquem @amcp

What does it take to finish the upgrade to AWS SDK v2 and publish it to maven.

There seems to be great interest in this project as it's a simple and reliable distributed lock.

If you have time to review and engage then perhaps the community using the tool can help with this upgrade?

Thanks.

Regards,
Martin

@humanzz
Copy link

humanzz commented Mar 31, 2022

Hi team, any updates on this?

@biscout42
Copy link

Hi team, do you have any plans to release sdk v2 support?

@dmytrodanilenkov
Copy link

dmytrodanilenkov commented Sep 9, 2022

@artembilan I probably can finish this issue. As I understand, main thing we need to do is return metrics collector support. But as I see here https://aws.amazon.com/ru/blogs/developer/using-the-new-client-side-metrics-feature-in-the-aws-sdk-for-java-v2/ , it's not required anymore. So we can just change groupId to software.amazon.awssdk instead com.amazonaws and release it

@shetsa-amzn
Copy link
Collaborator

Newer version of Amazon DynamoDB Lock Client(1.2.0) available on Maven now

https://repo1.maven.org/maven2/com/amazonaws/dynamodb-lock-client/1.2.0/

This change includes AWS SDK upgraded to 2.20.8

@dlabey
Copy link

dlabey commented Feb 28, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment