Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should worker.shutdown() return a future for client to wait for the finalShutdown to be completed for worker to coordinate clean shutdown of system that uses the kinesis worker? #87

Closed
Jae opened this issue Jul 18, 2016 · 3 comments

Comments

@Jae
Copy link

Jae commented Jul 18, 2016

Hi I've came across a situation to wait for final shutodnw of kinesis worker to initiate orderly shutdown of the whole system that uses kinesis worker. I couldn't find a simple way to wait for the complete shutdown of kinesis worker. I might be missing the obvious.

If it's not possible, then would returning a future that you can wait on https://github.com/awslabs/amazon-kinesis-client/blob/master/src/main/java/com/amazonaws/services/kinesis/clientlibrary/lib/worker/Worker.java#L478 a good idea?

Regards
J

@pfifer
Copy link
Contributor

pfifer commented Aug 16, 2016

I'm working on something similar for #79, that would return a future which finishes once all record processors have terminated. This may not fulfill everything since some of the other threads could still be running e.g. the CloudWatch publishing thread.

@Jae
Copy link
Author

Jae commented Sep 12, 2016

oh cool thanks! I think that will probably cover most, as any shutdown cleanup would be related to the user supplied code that kinesis record processor runs.

@pfifer
Copy link
Contributor

pfifer commented Nov 10, 2016

Release 1.7.1 added support for graceful shutdown. Feel free to reopen this if you have more questions.

@pfifer pfifer closed this as completed Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants