ProcessRecordsInput.isAtShardEnd value is not passed to processRecords

[ktulinger]

Hello,

we identified a possible bug in handling the isAtShardEnd value for a record processor. When receiving the records in processRecords, the value of isAtShardEnd is always false.

After looking at the code base, it is never set in the builder object:

amazon-kinesis-client/amazon-kinesis-client/src/main/java/software/amazon/kinesis/lifecycle/ProcessTask.java

Lines 217 to 218 in bedae95

	final ProcessRecordsInput processRecordsInput = ProcessRecordsInput.builder().records(records).cacheExitTime(input.cacheExitTime()).cacheEntryTime(input.cacheEntryTime())
	.checkpointer(recordProcessorCheckpointer).millisBehindLatest(input.millisBehindLatest()).build();

We use alpakka kinesis library, which, we observed, relies on the shardEnd value to be correctly set in order to properly checkpoint the shards.

[sochi]

Akka's Alpakka Kinesis library relies on this functionality, see their ShardProcessor: https://github.com/akka/alpakka/blob/master/kinesis/src/main/scala/akka/stream/alpakka/kinesis/impl/ShardProcessor.scala

The library is packaged as akka-stream-alpakka-kinesis.

[stair-aws]

Thanks for your contribution! PR merged; closing issue.

This should be included in our next release which will likely be version 2.4.6.