Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check whether the stale DNS plugin needs to do a force topology refresh #283

Merged
merged 4 commits into from
Dec 21, 2022
Merged

fix: check whether the stale DNS plugin needs to do a force topology refresh #283

merged 4 commits into from
Dec 21, 2022

Conversation

karenc-bq
Copy link
Contributor

Summary

fix: check whether the stale DNS plugin needs to do a force topology refresh

Description

Additional Reviewers

@sergiyvamz

@karenc-bq karenc-bq requested a review from sergiyvamz December 9, 2022 18:29
@karenc-bq karenc-bq marked this pull request as ready for review December 12, 2022 18:34
sergiyvamz
sergiyvamz reviewed Dec 21, 2022
View reviewed changes
wrapper/src/main/java/software/amazon/jdbc/plugin/staledns/AuroraStaleDnsPlugin.java Outdated
@@ -56,6 +56,8 @@ public class AuroraStaleDnsPlugin extends AbstractConnectionPlugin {
private final PluginService pluginService;
private final AuroraStaleDnsHelper helper;

static final String IS_READER_COLUMN = "is_reader";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need it here in the plugin? Should we relocate it to the helper class?

@karenc-bq karenc-bq merged commit 8b31444 into aws:main Dec 21, 2022
@karenc-bq karenc-bq deleted the stale_dns branch December 21, 2022 22:58
@shunyy
Copy link

shunyy commented Jan 12, 2023

@karenc-bq Hi!

I have run some tests on my end with snapshots and it seems to be working great!
Do you have any plans to release these changes?

@karenc-bq
Copy link
Contributor Author

Hi @shunyy, thank you for testing out the changes.

Are you currently evaluating the driver for production use or do you have a timeline where you'd want an official release? We are aiming to do a aiming to do a release by end of January as there are other fixes that we want to include. #298.

For convenience, we do offer snapshot builds here that would contains the fix from this PR: https://github.com/awslabs/aws-advanced-jdbc-wrapper/blob/main/docs/using-the-jdbc-driver/UsingTheJdbcDriver.md#using-a-snapshot-of-the-driver

@shunyy
Copy link

shunyy commented Jan 16, 2023

@karenc-bq

Thanks for the reply!

I've been testing the snapshot version and wanted to use it in a production environment as soon as possible , but with the schedule you gave me, it's perfectly fine!

Looking forward to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davecramer davecramer davecramer left review comments

@sergiyvamz sergiyvamz sergiyvamz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karenc-bq @shunyy @davecramer @sergiyvamz