Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for larger ECC curves (P521) in the PKCS11 implementation #591

Open
2 tasks
gregbreen opened this issue Aug 16, 2023 · 0 comments
Open
2 tasks
Labels
CRT/IoT feature-request A feature should be added or improved. p2 This is a standard priority issue

Comments

@gregbreen
Copy link

Describe the feature

In attempting to use P521 with PKCS (SoftHSM), I encounter the AWS_ERROR_PKCS11_ENCODING_ERROR here:

return aws_raise_error(AWS_ERROR_PKCS11_ENCODING_ERROR);
. It seems to be the case that the buffer is too small for P521. P256 and P384 are fine.

Use Case

AWS IoT Core recently added ECDSA-P521 as a supported key type: https://aws.amazon.com/about-aws/whats-new/2023/07/aws-iot-core-new-certificate-signing-key-generation-algorithms/. The SDK should support all key algorithms supported by IoT Core.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@gregbreen gregbreen added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 16, 2023
@yasminetalby yasminetalby self-assigned this Aug 16, 2023
@yasminetalby yasminetalby added needs-review This issue or pull request needs review from a core team member. p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Aug 16, 2023
@jmklix jmklix added CRT/IoT and removed needs-review This issue or pull request needs review from a core team member. labels Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CRT/IoT feature-request A feature should be added or improved. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

3 participants