fix(aws-cdk): Java init template works on Windows (#1503)

aws · Jan 15, 2019 · 24f521a · 24f521a
1 parent 4e46d3c
commit 24f521a
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 24 deletions.
diff --git a/packages/aws-cdk/lib/api/cxapp/exec.ts b/packages/aws-cdk/lib/api/cxapp/exec.ts
@@ -78,6 +78,7 @@ export async function execProgram(aws: SDK, config: Settings): Promise<cxapi.Syn
       const proc = childProcess.spawn(commandLine[0], commandLine.slice(1), {
         stdio: ['ignore', 'inherit', 'inherit'],
         detached: false,
+        shell: true,
         env: {
           ...process.env,
           ...env

diff --git a/packages/aws-cdk/lib/init-templates/app/java/app.sh b/packages/aws-cdk/lib/init-templates/app/java/app.sh
diff --git a/packages/aws-cdk/lib/init-templates/app/java/cdk.json b/packages/aws-cdk/lib/init-templates/app/java/cdk.json
@@ -1,3 +1,3 @@
 {
-  "app": "/bin/bash ./app.sh"
+  "app": "mvn exec:java"
 }
diff --git a/packages/aws-cdk/lib/init-templates/app/java/pom.template.xml b/packages/aws-cdk/lib/init-templates/app/java/pom.template.xml
@@ -1,5 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
+<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"
+         xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
     <modelVersion>4.0.0</modelVersion>
 
     <groupId>com.myorg</groupId>
@@ -22,23 +23,13 @@
                 </configuration>
             </plugin>
 
-            <!-- Emit the classpath to ./.classpath.txt so cdk.json can use it -->
             <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-dependency-plugin</artifactId>
-                <version>2.8</version>
-                <executions>
-                <execution>
-                    <id>build-classpath</id>
-                    <phase>generate-sources</phase>
-                    <goals>
-                        <goal>build-classpath</goal>
-                    </goals>
-                    <configuration>
-                        <outputFile>.classpath.txt</outputFile>
-                    </configuration>
-                </execution>
-                </executions>
+                <groupId>org.codehaus.mojo</groupId>
+                <artifactId>exec-maven-plugin</artifactId>
+                <version>1.6.0</version>
+                <configuration>
+                    <mainClass>com.myorg.HelloApp</mainClass>
+                </configuration>
             </plugin>
         </plugins>
     </build>