refactor(sns): move subscribers to aws-sns-subscribers (#2804)

In accordance with new guidelines, we're centralizing cross-service
integrations into their own package. In this case, centralizing
SNS Subscribers into @aws-cdk/aws-sns-subscribers.

BREAKING CHANGE: using a queue, lambda, email, URL as SNS Subscriber now
requires an integration object from the `@aws-cdk/aws-sns-subscribers`
package.

Author: rix0rrr

packages/@aws-cdk/app-delivery/package-lock.json

@@ -1,6 +1,7 @@
 import autoscaling = require('@aws-cdk/aws-autoscaling');
 import lambda = require('@aws-cdk/aws-lambda');
 import sns = require('@aws-cdk/aws-sns');
+import subs = require('@aws-cdk/aws-sns-subscriptions');
 import { Construct } from '@aws-cdk/cdk';
 import { TopicHook } from './topic-hook';
 
@@ -15,7 +16,7 @@ export class FunctionHook implements autoscaling.ILifecycleHookTarget {
 
   public bind(scope: Construct, lifecycleHook: autoscaling.ILifecycleHook): autoscaling.LifecycleHookTargetConfig {
     const topic = new sns.Topic(scope, 'Topic');
-    topic.subscribeLambda(this.fn);
+    topic.addSubscription(new subs.LambdaSubscription(this.fn));
     return new TopicHook(topic).bind(scope, lifecycleHook);
   }
 }

packages/@aws-cdk/assert/package-lock.json

@@ -81,6 +81,7 @@
     "@aws-cdk/aws-iam": "^0.34.0",
     "@aws-cdk/aws-lambda": "^0.34.0",
     "@aws-cdk/aws-sns": "^0.34.0",
+    "@aws-cdk/aws-sns-subscriptions": "^0.34.0",
     "@aws-cdk/aws-sqs": "^0.34.0",
     "@aws-cdk/cdk": "^0.34.0"
   },
@@ -90,11 +91,12 @@
     "@aws-cdk/aws-iam": "^0.34.0",
     "@aws-cdk/aws-lambda": "^0.34.0",
     "@aws-cdk/aws-sns": "^0.34.0",
+    "@aws-cdk/aws-sns-subscriptions": "^0.34.0",
     "@aws-cdk/aws-sqs": "^0.34.0",
     "@aws-cdk/cdk": "^0.34.0"
   },
   "engines": {
     "node": ">= 8.10.0"
   },
   "stability": "experimental"
-}
+}