feat(aws-ec2): can now use PrefixList in ingress rules (#1360)

Expose the newly-added capability of using PrefixLists as peers for Security Group ingress rules.
aws · Dec 14, 2018 · c3cfcd5 · c3cfcd5
1 parent 9ebe28b
commit c3cfcd5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/packages/@aws-cdk/aws-ec2/lib/security-group-rule.ts b/packages/@aws-cdk/aws-ec2/lib/security-group-rule.ts
@@ -105,7 +105,7 @@ export class AnyIPv6 extends CidrIPv6 {
  * https://docs.aws.amazon.com/AmazonVPC/latest/UserGuide/vpc-endpoints.html
  */
 export class PrefixList implements ISecurityGroupRule, IConnectable {
-  public readonly canInlineRule = true;
+  public readonly canInlineRule = false;
   public readonly connections: Connections = new Connections({ securityGroupRule: this });
   public readonly uniqueId: string;
 
@@ -114,7 +114,7 @@ export class PrefixList implements ISecurityGroupRule, IConnectable {
   }
 
   public toIngressRuleJSON(): any {
-    throw new Error('Prefix lists can only be used for egress rules');
+    return { sourcePrefixListId: this.prefixListId };
   }
 
   public toEgressRuleJSON(): any {

diff --git a/packages/@aws-cdk/aws-ec2/test/test.security-group.ts b/packages/@aws-cdk/aws-ec2/test/test.security-group.ts
@@ -165,6 +165,7 @@ export = {
     for (const peer of peers) {
       for (const port of ports) {
         sg.connections.allowTo(peer, port);
+        sg.connections.allowFrom(peer, port);
       }
     }