fix(aws-cdk): fix bug in SSM Parameter Provider #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSM Parameter Provider Plugin was not properly updated for the new context provider protocol. It is now, and an integ test is added.
Merged
eladb
reviewed
Oct 28, 2018
| @@ -5,6 +5,9 @@ class MyStack extends cdk.Stack { | |||
| constructor(parent, id) { | |||
| super(parent, id); | |||
| new sns.Topic(this, 'topic'); | |||
|
|
|||
| console.log(new cdk.AvailabilityZoneProvider(this).availabilityZones); | |||
There was a problem hiding this comment.
I wonder if we should assert against the resulting value somehow
jonparker
pushed a commit
to jonparker/aws-cdk
that referenced
this pull request
Oct 29, 2018
SSM Parameter Provider Plugin was not properly updated for the new context provider protocol. It is now, and an integ test is added.
jonparker
pushed a commit
to jonparker/aws-cdk
that referenced
this pull request
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSM Parameter Provider Plugin was not properly updated
for the new context provider protocol. It is now,
and an integ test is added.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.