feat(aws-autoscaling): add instance AutoScaling #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's now possible to add autoscaling policies (step scaling, target tracking, and scheduled) to AutoScalingGroup. It's also possible to add lifecycle hooks to an AutoScalingGroup, which will publish messages to SQS queues or SNS topics. ALSO IN THIS COMMIT - Fix an issue where an invalid PauseTime is generated on AutoScalingGroup. Fixes #1042, fixes #1113.
…s-cdk into huijbers/instance-autoscaling
rix0rrr
force-pushed
the
huijbers/instance-autoscaling
branch
from
14436b1
to
14df8af
Compare
eladb
approved these changes
Nov 15, 2018
| might want to scale out if the CPU usage across your cluster starts to rise, | ||
| and scale in when it drops again. | ||
| * **By trying to keep a certain metric around a given value** (also known as | ||
| target tracking scaling); you might want to automatically scale out an in to |
| // ... | ||
| }); | ||
|
|
||
| // Step scaling |
|
|
||
| Note that in order to set up this scaling strategy, you will have to emit a | ||
| metric representing your worker utilization from your instances. After that, | ||
| rou would configure the scaling something like this: |
| the range they can scale over (by setting both `minCapacity` and | ||
| `maxCapacity` but changing their range over time). | ||
|
|
||
| A scheduled is expressed as a cron expression. There is a `Cron` helper class |
| the range they can scale over (by setting both `minCapacity` and | ||
| `maxCapacity` but changing their range over time). | ||
|
|
||
| A scheduled is expressed as a cron expression. There is a `Cron` helper class |
There was a problem hiding this comment.
Cron: can we extract it to a common module so we can reuse it in CloudWatch Events? [not critical for this PR of course, but at least raise an issue]
There was a problem hiding this comment.
Maybe. Two points against this:
- There are a couple of Cron syntaxes floating round. For example, for application autoscaling and EC2 autoscaling, the two syntaxes look like this:
cron(0 18 * * ?)
0 18 * * *
Note the cron() function, and the difference between * and ? for the DOW field.
Also, I think it's convenient that you use the Cron class from the library X if you're creating cron expression for library X. It would be less convenient if you had to find library Y to use its Cron class.
But I'll gladly make a ticket :)
There was a problem hiding this comment.
We could create a shared cron library and expose the relevant instance (perm cron-syntax) from the various usage points
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's now possible to add autoscaling policies (step scaling, target
tracking, and scheduled) to AutoScalingGroup. It's also possible to add
lifecycle hooks to an AutoScalingGroup, which will publish messages to
SQS queues or SNS topics.
ALSO IN THIS COMMIT
AutoScalingGroup.
Fixes #1042, fixes #1113.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.