fix(aws-cdk): make bootstrapping not require --app #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the error message when needing to bootstrap while using assets. Also make it not necessary to have '--app' in there when bootstrapping if an environment name is given. This makes the toolkit easier to use in integration tests, where the cdk.json is generated and it's not clear what the argument to --app should be (nor should it be necessary if the environment identifier has enough information in it to reconstruct the Environment object). This also refactors the code somewhat so related code (for running the CX App and parsing its output) is together. Fixes #1188.
|
Did run the integ tests. |
RomainMuller
approved these changes
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the error message when needing to bootstrap while using assets.
Also make it not necessary to have '--app' in there when bootstrapping
if an environment name is given.
This makes the toolkit easier to use in integration tests, where the
cdk.json is generated and it's not clear what the argument to --app
should be (nor should it be necessary if the environment identifier has
enough information in it to reconstruct the Environment object).
This also refactors the code somewhat so related code (for running the
CX App and parsing its output) is together.
Fixes #1188.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.