Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IcmpPing does not emit ToPort value #1231

Closed
richardnagle opened this issue Nov 21, 2018 · 0 comments · Fixed by #1235
Closed

IcmpPing does not emit ToPort value #1231

richardnagle opened this issue Nov 21, 2018 · 0 comments · Fixed by #1235
Assignees
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud bug This issue is a bug.

Comments

@richardnagle
Copy link

Using the IcmpPing class like so:

 sg.addIngressRule(new AnyIPv4(), new IcmpPing(), "Allow Ping");

Creates the following output from cdk synth

          {
            "CidrIp": "0.0.0.0/0",
            "Description": "Allow Ping",
            "FromPort": 8,
            "IpProtocol": "icmp"
          }

This is missing the ToPort value and will fail when cdk deploy is executed.

@rix0rrr rix0rrr added bug This issue is a bug. @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud labels Nov 21, 2018
@rix0rrr rix0rrr self-assigned this Nov 21, 2018
rix0rrr pushed a commit that referenced this issue Nov 22, 2018
IcmpPing used to generate a piece of ingress/egress rule that would not
deploy. Added to integration test to make sure.

Fixes #1231.
rix0rrr added a commit that referenced this issue Nov 22, 2018
IcmpPing used to generate a piece of ingress/egress rule that would not
deploy. Added to integration test to make sure.

Fixes #1231.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud bug This issue is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants