Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI commands with -h flag still run #1259

Closed
awood45 opened this issue Nov 28, 2018 · 1 comment · Fixed by #1274
Closed

CLI commands with -h flag still run #1259

awood45 opened this issue Nov 28, 2018 · 1 comment · Fixed by #1274
Labels
bug This issue is a bug. package/tools Related to AWS CDK Tools or CLI

Comments

@awood45
Copy link
Member

awood45 commented Nov 28, 2018

Generally, CLI commands run with a -h flag have a behavior expectation that the action will not take place, and that a help message will be displayed instead.

Currently, a command like cdk deploy -h will run the deployment command.

While it's very reasonable for a flag to throw an error if desired (such as "use a different command structure to see a help message"), this definitely led to customer surprise for me.
@rix0rrr
Copy link
Contributor

rix0rrr commented Nov 29, 2018

Agreed, sounds like a bug.

@rix0rrr rix0rrr added bug This issue is a bug. package/tools Related to AWS CDK Tools or CLI labels Nov 29, 2018
rix0rrr added a commit that referenced this issue Dec 3, 2018
@rix0rrr
fix(aws-cdk): add '-h' flag to bring up help
4139f72 
We used to only show welp on `--help`, now we also show help on `-h`.
This matches user expectation with most commands.

Fixes #1259.
@rix0rrr rix0rrr mentioned this issue Dec 3, 2018
Merged
9 tasks
rix0rrr added a commit that referenced this issue Dec 4, 2018
@rix0rrr
fix(aws-cdk): add '-h' flag to bring up help (#1274)
47dafb0 
We used to only show welp on `--help`, now we also show help on `-h`.
This matches user expectation with most commands.

Fixes #1259.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(aws-cdk): show help on '-h' aws/aws-cdk
2 participants
@rix0rrr @awood45