Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-cdk): show help on '-h' #1274

Merged
merged 1 commit into from
Dec 4, 2018
Merged

fix(aws-cdk): show help on '-h' #1274

merged 1 commit into from
Dec 4, 2018

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Dec 3, 2018

We used to only show welp on --help, now we also show help on -h.
This matches user expectation with most commands.

Fixes #1259.


Pull Request Checklist

Please check all boxes (including N/A items)

Testing

  • Unit test and/or integration test added
  • Toolkit change?: integration
    tests

    manually executed (paste output to the PR description)
  • Init template change?: coordinated update of integration tests
    (currently maintained in a private repo).

Documentation

  • README: README and/or documentation topic updated
  • jsdocs: All public APIs documented

Title and description

  • Change type: Title is prefixed with change type:
    • fix(module): <title> bug fix (patch)
    • feat(module): <title> feature/capability (minor)
    • chore(module): <title> won't appear in changelog
    • build(module): <title> won't appear in changelog
  • Title format: Title uses lower case and doesn't end with a period
  • Breaking change?: Last paragraph of description is: BREAKING CHANGE: <describe exactly what changed and how to achieve similar behavior + link to documentation/gist/issue if more details are required>
  • References: Indicate issues fixed via: Fixes #xxx or Closes #xxx

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

We used to only show welp on `--help`, now we also show help on `-h`.
This matches user expectation with most commands.

Fixes #1259.
@rix0rrr rix0rrr requested review from RomainMuller and eladb December 3, 2018 09:46
@rix0rrr rix0rrr merged commit 47dafb0 into master Dec 4, 2018
@rix0rrr rix0rrr deleted the huijbers/cdk-h branch December 4, 2018 09:05
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI commands with -h flag still run
3 participants