Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

step-functions: implement IEventRuleTarget, add grant() methods #1275

Closed
rix0rrr opened this issue Dec 3, 2018 · 1 comment
Closed

step-functions: implement IEventRuleTarget, add grant() methods #1275

rix0rrr opened this issue Dec 3, 2018 · 1 comment
Assignees
@nija-at
Labels
@aws-cdk/aws-stepfunctions Related to AWS StepFunctions feature-request A feature should be added or improved.

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Dec 3, 2018

To improve the usability of Step Functions library, we should do these things.

Came up on Gitter channel.

(While at it, Chain() has a crazy constructor signature, which should mostly have been a copy constructor I think)
@rix0rrr rix0rrr added feature-request A feature should be added or improved. @aws-cdk/aws-stepfunctions Related to AWS StepFunctions labels Dec 3, 2018
@rix0rrr rix0rrr added the gap label Jan 4, 2019
rix0rrr added a commit that referenced this issue Jan 18, 2019
@rix0rrr
fix(aws-stepfunctions): explicitly implement IEventRuleTarget
c51f342 
So that Java/.NET users can trigger StateMachine from CWE.

Fixes part of #1275.
@rix0rrr rix0rrr mentioned this issue Jan 18, 2019
Merged
4 tasks
rix0rrr added a commit that referenced this issue Jan 22, 2019
@rix0rrr
fix(aws-events): ergonomics improvements to CloudWatch Events (#1570)
5e91a0a 
Fixes the following things for CloudWatch events:

* Support newlines in CloudWatch Events textTemplate as intended, by making a newline-separated list of JSON strings. Fixes #1514.
*  `jsonTemplate` now accepts arbitrary objects. They will be JSONified automatically. Fixes #1198.
* Explicitly implement `IEventRuleTarget` on stepfunctions StateMachine so that Java/.NET users can trigger StateMachines using CloudWatch Events. Fixes part of #1275.
sam-goodwin pushed a commit that referenced this issue Jan 28, 2019
@rix0rrr
fix(aws-events): ergonomics improvements to CloudWatch Events (#1570)
912d897 
Fixes the following things for CloudWatch events:

* Support newlines in CloudWatch Events textTemplate as intended, by making a newline-separated list of JSON strings. Fixes #1514.
*  `jsonTemplate` now accepts arbitrary objects. They will be JSONified automatically. Fixes #1198.
* Explicitly implement `IEventRuleTarget` on stepfunctions StateMachine so that Java/.NET users can trigger StateMachines using CloudWatch Events. Fixes part of #1275.
@eladb eladb mentioned this issue Feb 24, 2019
Closed
7 tasks
@rix0rrr rix0rrr assigned nija-at and unassigned rix0rrr Jan 23, 2020
@SomayaB SomayaB removed the gap label Feb 25, 2020
@nija-at nija-at changed the title step-functions: implement IEventRuleTarget, add grant() methods step-functions: implement IEventRuleTarget Feb 28, 2020
@nija-at nija-at changed the title step-functions: implement IEventRuleTarget step-functions: implement IEventRuleTarget, add grant() methods Feb 28, 2020
@nija-at
Copy link
Contributor

nija-at commented Feb 28, 2020

StateMachine now has grantStartExecution() API and a state machine event target

Closing.

@nija-at nija-at closed this as completed Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nija-at nija-at

Labels
@aws-cdk/aws-stepfunctions Related to AWS StepFunctions feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rix0rrr @nija-at @SomayaB