feat(aws-s3-deployment): Cleanup temp directory after sync

[dnakov]

The deployment lambda function tmp dir can get filled up and errors out with "no disk space left" if it's warm.

---

Pull Request Checklist

Please check all boxes, including N/A items:

Testing

• Unit test and/or integration test added
• Toolkit change?: integration tests manually executed (paste output to the PR description)
• Init template change?: coordinated update of integration tests (currently maintained in a private repo).

Documentation

• README: README and/or documentation topic updated
• jsdocs: All public APIs documented

Title and description

• Change type: Title is prefixed with change type:
  • fix(module): <title> bug fix (patch)
  • feat(module): <title> feature/capability (minor)
  • chore(module): <title> won't appear in changelog
  • build(module): <title> won't appear in changelog
• Title format: Title uses lower case and doesn't end with a period
• Breaking change?: Last paragraph of description is: BREAKING CHANGE: <describe exactly what changed and how to achieve similar behavior + link to documentation/gist/issue if more details are required>
• References: Indicate issues fixed via: Fixes #xxx or Closes #xxx

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

[RomainMuller]

Oh that's a nice suggestion - however I would rather switch to an implementation that leverages:

with tempfile.TemporaryDirectory() as workdir:
    # The stuff

This would guarantee the temporary directory gets cleaned, even if an error is thrown, and that's a little more elegant than writing a try ... catch.

What do you think?

[dnakov]

@RomainMuller I can add it but it seems redundant -- the code above ensures that directory will exist

[rix0rrr]

I can add it but it seems redundant -- the code above ensures that directory will exist

That would then also replace the mkdir

[rix0rrr]

Approving on the grounds that this at least makes the situation better (even if still not ideal).