feat(aws-codebuild): allow setting Webhook for GitHub Sources #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
approved these changes
Dec 18, 2018
| /** | ||
| * Whether to create a webhook that will trigger a build every time a commit is pushed to the GitHub repository. | ||
| * | ||
| * @default true |
There was a problem hiding this comment.
true? Not sure this makes sense as the default...
There was a problem hiding this comment.
Sure, will change to false.
skinny85
force-pushed
the
feature/codebuild-webhook
branch
from
5d2ca77
to
1755594
Compare
|
Changed the default to |
skinny85
force-pushed
the
feature/codebuild-webhook
branch
from
1755594
to
6f1f7e1
Compare
|
Accidentally changed the JSDocs of the |
eladb
approved these changes
Dec 19, 2018
skinny85
force-pushed
the
feature/codebuild-webhook
branch
from
6f1f7e1
to
633960b
Compare
|
Rebased on top of the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack Overflow question: https://stackoverflow.com/questions/53761833/aws-codebuild-webhook-in-aws-cdk/53770453
Pull Request Checklist
Please check all boxes, including N/A items:
Testing
Documentation
Title and description
fix(module): <title>bug fix (patch)feat(module): <title>feature/capability (minor)chore(module): <title>won't appear in changelogbuild(module): <title>won't appear in changelogBREAKING CHANGE: <describe exactly what changed and how to achieve similar behavior + link to documentation/gist/issue if more details are required>Fixes #xxxorCloses #xxxBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.