Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-lambda): add input and output Artifacts to the CodePipeline Action #1390

Merged

Conversation

skinny85
Copy link
Contributor

Fixes #1384


Pull Request Checklist

Please check all boxes, including N/A items:

Testing

  • Unit test and/or integration test added
  • Toolkit change?: integration tests manually executed (paste output to the PR description)
  • Init template change?: coordinated update of integration tests (currently maintained in a private repo).

Documentation

  • README: README and/or documentation topic updated
  • jsdocs: All public APIs documented

Title and description

  • Change type: Title is prefixed with change type:
    • fix(module): <title> bug fix (patch)
    • feat(module): <title> feature/capability (minor)
    • chore(module): <title> won't appear in changelog
    • build(module): <title> won't appear in changelog
  • Title format: Title uses lower case and doesn't end with a period
  • Breaking change?: Last paragraph of description is: BREAKING CHANGE: <describe exactly what changed and how to achieve similar behavior + link to documentation/gist/issue if more details are required>
  • References: Indicate issues fixed via: Fixes #xxx or Closes #xxx

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@skinny85 skinny85 requested a review from a team as a code owner December 18, 2018 23:50
@skinny85 skinny85 force-pushed the feature/lambda-pipeline-inputs-outputs branch from 1fe7c62 to c0dc948 Compare December 19, 2018 19:46
@skinny85
Copy link
Contributor Author

Rebased on top of the new master to get the builds going again (master was broken before).

packages/@aws-cdk/aws-lambda/README.md Show resolved Hide resolved
@@ -9,6 +9,22 @@ import { FunctionRef } from './lambda-ref';
* or through {@link FunctionRef#addToPipeline}.
*/
export interface CommonPipelineInvokeActionProps extends codepipeline.CommonActionProps {
/**
* The optional input Artifacts of the Action.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe provide some pointers as to how to read the input artifacts from the lambda code and how to produce the output artifacts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@skinny85 skinny85 force-pushed the feature/lambda-pipeline-inputs-outputs branch from c0dc948 to e1700ce Compare December 21, 2018 02:12
@skinny85 skinny85 merged commit fbd7728 into aws:master Dec 21, 2018
@skinny85 skinny85 deleted the feature/lambda-pipeline-inputs-outputs branch December 21, 2018 17:59
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for input and output artifacts in the Lambda invoke CodePipeline Action
3 participants