-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elbv2: Set load balancer name seems doesn't work #1481
Labels
Comments
rix0rrr
added
bug
This issue is a bug.
@aws-cdk/aws-elasticloadbalancing
Related to Amazon Elastic Load Balancing
labels
Jan 6, 2019
eladb
pushed a commit
that referenced
this issue
Jan 7, 2019
Since #973, the renames of CFN properties from "name" to "xxxName" were removed. But the ELBv2 library still used `loadBalancerName`. The reason this was not discovered was because we are splatting `additionalProps` of type `any`, and this caused the type checker to stop verifying property names. Fixes #1481
4 tasks
eladb
pushed a commit
that referenced
this issue
Jan 7, 2019
Since #973, the renames of CFN properties from "name" to "xxxName" were removed. But the ELBv2 library still used `loadBalancerName`. The reason this was not discovered was because we are splatting `additionalProps` of type `any`, and this caused the type checker to stop verifying property names. Fixes #1481
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
my code:
Load balancer got created:
Name: ECSGr-ALB1F-1RGPT2HCXKOZL
Expect to be 'myalb'
The text was updated successfully, but these errors were encountered: