fix(aws-ec2): change maxAZs default for VPCs to 3 #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For most users, default deployments of a VPC in `us-east-1` would fail because that region has more AZs (6) than the allowed EIP allocations in an acccount (5). This is a very poor experience. Plus, it is wasteful since there is not much additional value in using more than 3 AZs for a VPC. Fixes #996.
eladb
approved these changes
Jan 14, 2019
| @@ -58,7 +58,7 @@ export interface VpcNetworkProps { | |||
| * If the region has more AZs than you want to use (for example, because of EIP limits), | |||
| * pick a lower number here. The AZs will be sorted and picked from the start of the list. | |||
| * | |||
| * @default All AZs in the region | |||
| * @default 3 | |||
There was a problem hiding this comment.
Indicate what users should do if they want to use all AZs (even if it's "99")
eladb
approved these changes
Jan 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For most users, default deployments of a VPC in
us-east-1would failbecause that region has more AZs (6) than the allowed EIP allocations in
an acccount (5).
This is a very poor experience. Plus, it is wasteful since there is
not much additional value in using more than 3 AZs for a VPC.
Fixes #996.
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.