Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-events): ergonomics improvements to CloudWatch Events #1570

Merged
merged 3 commits into from
Jan 22, 2019

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jan 18, 2019

Fixes the following things for CloudWatch events:


Pull Request Checklist

  • Testing
    • Unit test added
    • CLI change?: manually run integration tests and paste output as a PR comment
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Support newlines in CloudWatch Events textTemplate as intended, by
making a newline-separated list of JSON strings.

Fixes #1514.
They will be JSONified automatically.

Fixes #1198.
So that Java/.NET users can trigger StateMachine from CWE.

Fixes part of #1275.
@rix0rrr rix0rrr requested a review from a team as a code owner January 18, 2019 10:42
@sam-goodwin sam-goodwin added the @aws-cdk/aws-events Related to CloudWatch Events label Jan 18, 2019
@rix0rrr rix0rrr merged commit 5e91a0a into master Jan 22, 2019
@rix0rrr rix0rrr deleted the huijbers/cwe-improvements branch January 22, 2019 23:13
sam-goodwin pushed a commit that referenced this pull request Jan 28, 2019
Fixes the following things for CloudWatch events:

* Support newlines in CloudWatch Events textTemplate as intended, by making a newline-separated list of JSON strings. Fixes #1514.
*  `jsonTemplate` now accepts arbitrary objects. They will be JSONified automatically. Fixes #1198.
* Explicitly implement `IEventRuleTarget` on stepfunctions StateMachine so that Java/.NET users can trigger StateMachines using CloudWatch Events. Fixes part of #1275.
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-events Related to CloudWatch Events contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CloudWatch events: multi-line target input template is broken Allow fixed string input to CW Event
4 participants