Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-ecs): Add scaling ECS service on ALB Request Count #1574

Merged
merged 6 commits into from
Jan 21, 2019

Conversation

BDQ
Copy link
Contributor

@BDQ BDQ commented Jan 18, 2019

Adds a scaleOnRequestCount inline with scaleOnCpuUtilization and scaleOnMemoryUtilization


Pull Request Checklist

  • Testing
    • Unit test added
    • CLI change?: manually run integration tests and paste output as a PR comment
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@BDQ BDQ requested review from SoManyHs and a team as code owners January 18, 2019 19:05
@sam-goodwin sam-goodwin added feature-request A feature should be added or improved. @aws-cdk/aws-ecs Related to Amazon Elastic Container labels Jan 18, 2019
@BDQ
Copy link
Contributor Author

BDQ commented Jan 21, 2019

@rix0rrr that formatting commit seems to have angered the linter:

@aws-cdk/aws-ecs: > @aws-cdk/aws-ecs@0.22.0 build /home/travis/build/awslabs/aws-cdk/packages/@aws-cdk/aws-ecs
@aws-cdk/aws-ecs: > cdk-build
@aws-cdk/aws-ecs: ERROR: /home/travis/build/awslabs/aws-cdk/packages/@aws-cdk/aws-ecs/lib/base/scalable-task-count.ts:50:1 - trailing whitespace
@aws-cdk/aws-ecs: Error: tslint --project . exited with error code 2

@rix0rrr
Copy link
Contributor

rix0rrr commented Jan 21, 2019

Oh that's fun. The GitHub editor will always insert a trailing newline to the file, and our linter always complains about it.

@rix0rrr rix0rrr merged commit 2b491d4 into aws:master Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container feature-request A feature should be added or improved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants