Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make roleName available on IRole #1589

Merged
merged 2 commits into from
Jan 22, 2019
Merged

feat: Make roleName available on IRole #1589

merged 2 commits into from
Jan 22, 2019

Conversation

RomainMuller
Copy link
Contributor

The iam.Policy class expected to be provided (concrete) Role instances,
making it unusable when all that is available is an IRole (as should be in
most situations). This changes the API to accept an IRole instead, increasing
the usability.

Pull Request Checklist

  • Testing
    • Unit test added
    • CLI change?: manually run integration tests and paste output as a PR comment
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@RomainMuller
feat: Make roleName available on IRole
3ed14a4 
The `iam.Policy` class expected to be provided (concrete) `Role` instances,
making it unusable when all that is available is an `IRole` (as should be in
most situations). This changes the API to accept an `IRole` instead, increasing
the usability.
@RomainMuller RomainMuller requested a review from a team as a code owner January 22, 2019 01:58
@RomainMuller RomainMuller merged commit 9128390 into master Jan 22, 2019
@RomainMuller RomainMuller deleted the rmuller/use-i-role branch January 22, 2019 17:45
sam-goodwin pushed a commit that referenced this pull request Jan 28, 2019
@RomainMuller
feat: Make roleName available on IRole (#1589)
206c577 
The `iam.Policy` class expected to be provided (concrete) `Role` instances,
making it unusable when all that is available is an `IRole` (as should be in
most situations). This changes the API to accept an `IRole` instead, increasing
the usability.
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RomainMuller @rix0rrr @NGL321