Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(autoscaling): Support AssociatePublicIpAddress #1604

Merged
merged 2 commits into from
Jan 24, 2019
Merged

feat(autoscaling): Support AssociatePublicIpAddress #1604

merged 2 commits into from
Jan 24, 2019

Conversation

otterley
Copy link
Contributor

Allow AssociatePublicIpAddress property to be specified in ASG Launch
Configuration.

Fixes #1603

Pull Request Checklist

  • Testing
    • Unit test added
    • CLI change?: manually run integration tests and paste output as a PR comment
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@otterley
feat(autoscaling): Support AssociatePublicIpAddress
b074e0f 
Allow AssociatePublicIpAddress property to be specified in ASG Launch
Configuration.
@otterley otterley requested a review from a team as a code owner January 23, 2019 22:11
rix0rrr
rix0rrr reviewed Jan 23, 2019
View reviewed changes
packages/@aws-cdk/aws-autoscaling/test/test.auto-scaling-group.ts
expect(stack).to(haveResource("AWS::AutoScaling::LaunchConfiguration", (resource: any, errors: InspectionFailure) => {
for (const key of Object.keys(resource)) {
if (key === "AssociatePublicIpAddress") {
errors.failureReason = "Has AssociatePublicIpAddress";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, neat trick.

rix0rrr
rix0rrr approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the help!

I changed the doc comment a bit, will merge as soon as the build clears.

@rix0rrr rix0rrr merged commit 23c9afc into aws:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto Scaling: support associatePublicIpAddress in Launch Configuration
2 participants
@otterley @rix0rrr