Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cdk): treat the "fake" CFN intrinsics specially when stringifying JSON #1605

Merged
merged 1 commit into from
Jan 23, 2019
Merged

feat(cdk): treat the "fake" CFN intrinsics specially when stringifying JSON #1605

merged 1 commit into from
Jan 23, 2019

Conversation

skinny85
Copy link
Contributor

Fn::GetArtifactAtt and Fn::GetParam are not really intrinsics,
they're functions that can be used only in CodePipeline CFN Actions,
in the parameterOverride property.

More information: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/continuous-delivery-codepipeline-parameter-override-functions.html

Fixes #1588

Pull Request Checklist

  • Testing
    • Unit test added
    • CLI change?: manually run integration tests and paste output as a PR comment
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@skinny85
feat(cdk): treat the "fake" CFN intrinsics (Fn::GetArtifactAtt, Fn::G…
d092488 
…etParam) specially when stringifying JSON.

Fn::GetArtifactAtt and Fn::GetParam are not really intrinsics,
they're functions that can be used only in CodePipeline CFN Actions,
in the `parameterOverride` property.

More information: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/continuous-delivery-codepipeline-parameter-override-functions.html

Fixes aws#1588
@skinny85 skinny85 requested a review from rix0rrr January 23, 2019 22:34
@skinny85 skinny85 requested review from RomainMuller and a team as code owners January 23, 2019 22:34
@skinny85 skinny85 mentioned this pull request Jan 23, 2019
Closed
@skinny85 skinny85 merged commit 2af2426 into aws:master Jan 23, 2019
@skinny85 skinny85 deleted the feature/fake-intrinsics branch September 10, 2019 16:38
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

@RomainMuller RomainMuller Awaiting requested review from RomainMuller

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[aws-codepipeline] Parameter overrides cannot use Fn::GetArtifactAtt
3 participants
@skinny85 @rix0rrr @NGL321