Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add datapointsToAlarm to AlarmProps and NewAlarmProps #1626

Closed
defel opened this issue Jan 28, 2019 · 0 comments · Fixed by #1631
Closed

add datapointsToAlarm to AlarmProps and NewAlarmProps #1626

defel opened this issue Jan 28, 2019 · 0 comments · Fixed by #1631
Assignees
@RomainMuller
Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch

Comments

@defel
Copy link

defel commented Jan 28, 2019 •
edited
Loading

Hi,

please add datapointsToAlarm to AlarmProps and NewAlarmProps

Docs: https://awslabs.github.io/aws-cdk/refs/_aws-cdk_aws-cloudwatch.html#@aws-cdk/aws-cloudwatch.CfnAlarmProps.datapointsToAlarm

Add field:

  /**
  * Data points are defined by the period set for a metric. For a “1 minute” period, there is one data point every minute.
  */
  datapointsToAlarm?: number

to AlarmProps: https://github.com/awslabs/aws-cdk/blob/fb22a328f8a0dc9f1a97644990ed61314971e05c/packages/%40aws-cdk/aws-cloudwatch/lib/alarm.ts#L10-L71

Add field:

  datapointsToAlarm: datapointsToAlarm,

to Alarm: https://github.com/awslabs/aws-cdk/blob/fb22a328f8a0dc9f1a97644990ed61314971e05c/packages/%40aws-cdk/aws-cloudwatch/lib/alarm.ts#L153-L158

Add field:

  datapointsToAlarm?: number

to NewAlarmProps: https://github.com/awslabs/aws-cdk/blob/fb22a328f8a0dc9f1a97644990ed61314971e05c/packages/%40aws-cdk/aws-cloudwatch/lib/metric.ts#L295-L375

Add field:

  datapointsToAlarm: props.datapointsToAlarm,

to newAlarm: https://github.com/awslabs/aws-cdk/blob/fb22a328f8a0dc9f1a97644990ed61314971e05c/packages/%40aws-cdk/aws-cloudwatch/lib/metric.ts#L145-L166
@skinny85 skinny85 added @aws-cdk/aws-cloudwatch Related to Amazon CloudWatch gap labels Jan 28, 2019
RomainMuller added a commit that referenced this issue Jan 29, 2019
@RomainMuller
feat(cloudwatch): Support 'datapointsToAlarm' on Alarms
5b47ebe 
Adds support for settingt the `dataPointsToAlarm` property of the
CloudWatch `Alarm`s (also via the `Metric`s).

Fixes #1626
@RomainMuller RomainMuller mentioned this issue Jan 29, 2019
Merged
4 tasks
@RomainMuller RomainMuller self-assigned this Jan 29, 2019
RomainMuller added a commit that referenced this issue Jan 30, 2019
@RomainMuller
feat(cloudwatch): Support 'datapointsToAlarm' on Alarms (#1631)
828ac20 
Adds support for settingt the `dataPointsToAlarm` property of the
CloudWatch `Alarm`s (also via the `Metric`s).

Fixes #1626
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomainMuller RomainMuller

Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cloudwatch): Support 'datapointsToAlarm' on Alarms aws/aws-cdk
3 participants
@defel @RomainMuller @skinny85