Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudwatch): Support 'datapointsToAlarm' on Alarms #1631

Merged
merged 2 commits into from
Jan 30, 2019

Conversation

RomainMuller
Copy link
Contributor

Adds support for settingt the dataPointsToAlarm property of the
CloudWatch Alarms (also via the Metrics).

Fixes #1626


Pull Request Checklist

  • Testing
    • Unit test added
    • CLI change?: manually run integration tests and paste output as a PR comment
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Adds support for settingt the `dataPointsToAlarm` property of the
CloudWatch `Alarm`s (also via the `Metric`s).

Fixes #1626
@RomainMuller RomainMuller requested a review from a team as a code owner January 29, 2019 13:10
@RomainMuller RomainMuller merged commit 828ac20 into master Jan 30, 2019
@RomainMuller RomainMuller deleted the rmuller/fix-1626 branch January 30, 2019 09:08
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add datapointsToAlarm to AlarmProps and NewAlarmProps
3 participants