Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toolkit): disable colors if a text terminal is not attached to stdout #1641

Merged
merged 1 commit into from
Jan 30, 2019

Conversation

sam-goodwin
Copy link
Contributor

Check if stdout is connected to a text terminal and disable colors if it is not. This allows developers to incorporate the output of the CLI into their workflow.

Fixes #1638

Pull Request Checklist

  • Testing
    • Unit test added
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@sam-goodwin sam-goodwin added the package/tools Related to AWS CDK Tools or CLI label Jan 30, 2019
@sam-goodwin sam-goodwin requested a review from a team as a code owner January 30, 2019 20:09
@sam-goodwin sam-goodwin merged commit 58b4685 into master Jan 30, 2019
@sam-goodwin sam-goodwin deleted the samgood/disable-colors branch January 30, 2019 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to pipe output of cdk diff to file (without colors)?
2 participants