Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-codepipeline): update cfn example #1653

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Jan 31, 2019

This test is referred as example in the Cloudformation README. But the example doesn't do what it intended. Without specify the runOrder the pipelineExecuteChangeSetAction will be triggered immediately without change set being populated, which will lead to deployment failure. After adding the runOrder the 3 actions will run in order and only be deployed after manual aproval


Pull Request Checklist

  • Testing
    • Unit test added
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@AllanZhengYP
Copy link
Contributor Author

Can anyone help me with the CI?

@eladb
Copy link
Contributor

eladb commented Feb 4, 2019

@skinny85 can you take a look please?

@skinny85
Copy link
Contributor

skinny85 commented Feb 4, 2019

Thanks for the contribution @AllanFly120 . Since this file is part of our integ tests, you also need to update its corresponding expectations file, integ.cfn-template-from-repo.lit.expected.json. You can do it by running npm run integ -- integ.cfn-template-from-repo.lit.js in the aws-codepipeline package, which will deploy, and then remove, the test Stack into your AWS account, and write out the contents of the expectation file. More info on our integ tests is here.

This test is referred as example in the [Cloudformation README](https://github.com/awslabs/aws-cdk/blob/master/packages/%40aws-cdk/aws-cloudformation/README.md).
But the example doesn't do what it intended.
Without specifying the runOrder the `pipelineExecuteChangeSetAction` will be triggered immediately without change set being populated,
which will lead to deployment failure.
After adding the `runOrder` the 3 actions will run in order and only be deployed after manual approval.
@skinny85
Copy link
Contributor

I updated the expected JSON file.

@skinny85 skinny85 merged commit 5dec01a into aws:master Feb 19, 2019
eladb pushed a commit that referenced this pull request Feb 26, 2019
This test is referred as example in the
[Cloudformation README](https://github.com/awslabs/aws-cdk/blob/master/packages/%40aws-cdk/aws-cloudformation/README.md).
But the example doesn't do what it intended.
Without specifying the runOrder the `pipelineExecuteChangeSetAction` will be triggered immediately without change set being populated,
which will lead to deployment failure.
After adding the `runOrder` the 3 actions will run in order and only be deployed after manual approval.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants