Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeploymentConfiguration minimumHealthyPercent incorrectly set to 50 when Service minimumHealthyPercent set to 0 #1660

Closed
Don-CA opened this issue Feb 4, 2019 · 0 comments · Fixed by #1661
Closed

DeploymentConfiguration minimumHealthyPercent incorrectly set to 50 when Service minimumHealthyPercent set to 0 #1660

Don-CA opened this issue Feb 4, 2019 · 0 comments · Fixed by #1661
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container bug This issue is a bug.

Comments

@Don-CA
Copy link
Contributor

Don-CA commented Feb 4, 2019

If the minimumHealthyPercent is set to 0 for an ECS Service (Fargate or EC2), the DeploymentConfiguration minimumHealthyPercent actually get set to 50.
@Don-CA Don-CA mentioned this issue Feb 4, 2019
Merged
4 tasks
@eladb eladb added bug This issue is a bug. @aws-cdk/aws-ecs Related to Amazon Elastic Container labels Feb 4, 2019
eladb pushed a commit that referenced this issue Feb 6, 2019
@Don-CA
fix(aws-ecs): correctly sets MinimumHealthyPercentage to 0 (#1661)
ce5966f 
Zero is a valid value for MinimumHealthyPercentage and therefore should
not be replaced with the default value.

BaseService now explicitly checks if minimumHealthyPercent is null
before setting default value: fixes #1660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(aws-ecs): correctly set MinimumHealthyPercentage to 0
2 participants
@eladb @Don-CA