fix(lambda): add a synth-time check for environment variables #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some regions Lambda environment variables don't work. Add a check for that so that there is quicker feedback on this missing feature.
eladb
approved these changes
Feb 6, 2019
| @@ -347,6 +347,12 @@ export class Function extends FunctionBase { | |||
| this.role.addToPolicy(statement); | |||
| } | |||
|
|
|||
| const stack = cdk.Stack.find(this); | |||
| const isChina = stack.env.region && stack.env.region.startsWith('cn-'); | |||
There was a problem hiding this comment.
maybe we should check if region is not a token? (cdk.unresolved)
| const stack = cdk.Stack.find(this); | ||
| const isChina = stack.env.region && stack.env.region.startsWith('cn-'); | ||
| if (isChina && props.environment && Object.keys(props.environment).length > 0) { | ||
| throw new Error(`Environment variables are not supported in this region (${stack.env.region}); please use tags or SSM parameters instead`); |
There was a problem hiding this comment.
rephrase "please use" to "you may consider using" or "you can use"
| @@ -1178,6 +1178,25 @@ export = { | |||
| test.done(); | |||
| }, | |||
|
|
|||
| 'environment variables are prohibited in China'(test: Test) { | |||
There was a problem hiding this comment.
Add a test for what happens when the region is undefined and when the region is a token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some regions Lambda environment variables don't work. Add a check
for that so that there is quicker feedback on this missing feature.
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.