Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(autoscaling): bring your own IAM role #1727

Merged
merged 2 commits into from
Feb 11, 2019
Merged

feat(autoscaling): bring your own IAM role #1727

merged 2 commits into from
Feb 11, 2019

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Feb 11, 2019 •
edited
Loading

Allow specifying an IAM role (IRole) when defining an AutoScalingGroup. This allows
either passing a role created in the same stack or passing in an imported role.

Fixes #1701

Pull Request Checklist

  • Testing
    • Unit test added
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

feat(autoscaling): bring your own IAM role
9d20aee 
Allow specifying an IAM role (`IRole`) when defining an AutoScalingGroup. This allows
either passing a role created in the same stack or passing in an imported role.

Fixes #1701
@eladb eladb requested a review from a team as a code owner February 11, 2019 14:49
RomainMuller
RomainMuller approved these changes Feb 11, 2019
View reviewed changes
packages/@aws-cdk/aws-autoscaling/lib/auto-scaling-group.ts
@@ -159,6 +159,12 @@ export interface AutoScalingGroupProps extends CommonAutoScalingGroupProps {
* AMI to launch
*/
machineImage: ec2.IMachineImageSource;

/**
* An IAM role to associate with the instance profile assigned to this Auto Scaling Group.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mention that the role must be assumable by { Service: ec2.amazonaws.com }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Added

@eladb eladb merged commit 2016b8d into master Feb 11, 2019
@eladb eladb deleted the benisrae/asg-role branch February 11, 2019 16:39
@fulghum fulghum added the effort/small Small work item – less than a day of effort label Feb 18, 2019
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 23, 2019
@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomainMuller RomainMuller RomainMuller approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow existing role when creating new AutoScalingGroup
4 participants
@eladb @RomainMuller @fulghum @NGL321