feat(core): Add construct.node.stack attribute
#1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it easier to access some construct's `Stack`, avoiding having to sprinkle `Stack.find(this)` everywhere. While there, added `construct.node.formatArn` and `construct.node.parseArn` as convenience methods to avoid indirecting via the `Stack`. BREAKING CHANGE: `Stack.find(c)` and `Stack.tryFind(c)` were replaced by `c.node.stack`. Fixes #798
RomainMuller
requested review from
skinny85,
SoManyHs and
a team
as code owners
eladb
suggested changes
Feb 13, 2019
There was a problem hiding this comment.
Not sure I like the formatArn/parseArn sugar... Why not mirror all of the Stack API then into node? I'd argue that stack.region and stack.account are way more prevalent than formatArn, but then where do you stop?
It also doesn't make sense when you read the code this.node.formatArn...
|
I had mixed feelings about those two sugars (they save a meager 5 characters, but on the other hand those were annoying to industrially type around :D). Removed those - this PR is now a Diet PR (the same great taste, one third of the sugar). |
RomainMuller
added
pr/breaking-change
eladb
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easier to access some construct's
Stack, avoidinghaving to sprinkle
Stack.find(this)everywhere.BREAKING CHANGE:
Stack.find(c)andStack.tryFind(c)werereplaced by
c.node.stack.Fixes #798
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.