fix: Npm ignores files and folders named "core" by default #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the release of `npm@6.8.0`, a version of `npm-packlist` is included that introduces a behavior to ignore anything named "core" by default. Added `!core` to the `.npmignore` file as a work around, and also more strictly pinned the `npm` version to auto-upgrade to so we don't get surprised in this kind of way anymore. Cause: npm/npm-packlist#24
rix0rrr
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the release of
npm@6.8.0, a version ofnpm-packlistisincluded that introduces a behavior to ignore anything named "core" by
default.
Added
!coreto the.npmignorefile as a work around, and also morestrictly pinned the
npmversion to auto-upgrade to so we don't getsurprised in this kind of way anymore.
Cause: npm/npm-packlist#24