Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApplicationTargetGroup doesn't implement IApplicationTargetGroup #1799

Closed
fulghum opened this issue Feb 19, 2019 · 1 comment · Fixed by #1806
Closed

ApplicationTargetGroup doesn't implement IApplicationTargetGroup #1799

fulghum opened this issue Feb 19, 2019 · 1 comment · Fixed by #1806

Comments

@fulghum
Copy link
Contributor

fulghum commented Feb 19, 2019

It seems like ApplicationTargetGroup should be implementing IApplicationTargetGroup, but it isn't:
https://github.com/awslabs/aws-cdk/blob/master/packages/%40aws-cdk/aws-elasticloadbalancingv2/lib/alb/application-target-group.ts#L65

I ran into this while porting Nathan Peck's ECS blog post sample code to Java:
https://aws.amazon.com/blogs/compute/getting-started-with-the-aws-cloud-development-kit-for-amazon-ecs/

Without this, I couldn't figure out how to call ApplicationListener.addTargetGroups and set the target groups in the AddApplicationTargetGroupProps class:
https://github.com/awslabs/aws-cdk/blob/master/packages/%40aws-cdk/aws-elasticloadbalancingv2/lib/alb/application-listener.ts#L459
rix0rrr pushed a commit that referenced this issue Feb 20, 2019
fix(elbv2): explicitly implement IApplicationTargetGroup
2f43934 
Fix usage of application and network target groups in languages
without structural typing, such as Java and C#.

Fixes #1799.
@rix0rrr rix0rrr mentioned this issue Feb 20, 2019
Merged
4 tasks
rix0rrr added a commit that referenced this issue Feb 22, 2019
@rix0rrr
fix(elbv2): explicitly implement IApplicationTargetGroup (#1806)
828a2d7 
Fix usage of application and network target groups in languages
without structural typing, such as Java and C#.

Fixes #1799.
@fulghum
Copy link
Contributor Author

fulghum commented Feb 22, 2019

w00t! thank you @rix0rrr 😉

eladb pushed a commit that referenced this issue Feb 26, 2019
@rix0rrr
fix(elbv2): explicitly implement IApplicationTargetGroup (#1806)
1b81758 
Fix usage of application and network target groups in languages
without structural typing, such as Java and C#.

Fixes #1799.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(elbv2): explicitly implement IApplicationTargetGroup aws/aws-cdk
1 participant
@fulghum