Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename construct's "name" parameter to "id" or "cid" or "conid" #189

Closed
eladb opened this issue Jun 28, 2018 · 2 comments
Closed

Rename construct's "name" parameter to "id" or "cid" or "conid" #189

eladb opened this issue Jun 28, 2018 · 2 comments
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved.

Comments

@eladb
Copy link
Contributor

eladb commented Jun 28, 2018 •
edited
Loading

Feedback from @skinny85, which I agree. The "name" terminology is easily confused with the physical name of the resource. We should use id.

See #1423 - we should consider perhaps to give IDs a more distinctive name such as "cid" or "conid" so that people will understand that these have a few limitations (for example, you can't use tokens).
@eladb
Copy link
Contributor Author

eladb commented Jun 28, 2018

@rix0rrr what do you think about this?

Thankfully, this is not a breaking change...

@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 29, 2018

Potato, potato. Let's do it!

@fulghum fulghum added the effort/small Small work item – less than a day of effort label Dec 18, 2018
@eladb eladb changed the title Rename construct's "name" parameter to "id" Rename construct's "name" parameter to "id" or "cid" or "conid" Dec 23, 2018
@eladb eladb mentioned this issue Dec 27, 2018
Merged
4 tasks
@eladb eladb closed this as completed in fb22a32 Jan 3, 2019
@srchase srchase added feature-request A feature should be added or improved. and removed enhancement labels Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fulghum @rix0rrr @eladb @srchase