-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(toolkit): add '--reuse-asset' option #1918
Conversation
Reusing assets avoids rebuilding an asset and just reuses the currently deployed one. Especially helpful for Docker containers that take a long time to build. Fixes #1916
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should just be --no-build
. @sam-goodwin is planning to add a distinct "build" command to the toolkit, so I envision deploy --no-build
to have the effect you want with less ugliness...
I actually had And ultimately, I prefer the name to be positive, so you don't have the problem with double negatives. |
you just specify --build and --no-build feel much more forward looking and less a hack than the current approach. |
So you propose to either build all assets or no assets? Wouldn't have helped me in my case though, where I did want to update a Lambda but did not want to rebuild the Docker image. I explicitly chose for selective control over which asset gets reused. |
And I agree with the "hack" terminology insofar as that the |
got it. So how about |
Reusing assets avoids rebuilding an asset and just reuses the currently
deployed one. Especially helpful for Docker containers that take a long
time to build.
Fixes #1916
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.