Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudfront): Pass viewerProtocolPolicy to the distribution's behaviors #1932

Merged
merged 2 commits into from
Mar 7, 2019

Conversation

skorfmann
Copy link
Contributor

@skorfmann skorfmann commented Mar 3, 2019

The viewerProtocolPolicy setting wasn't respected, since the configuration wasn't passed along. Hence, the default ViewerProtocolPolicy.RedirectToHTTPS was kicking in all the time.

Would appreciate hints for testing.

Fixes #1801


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@skorfmann skorfmann requested a review from a team as a code owner March 3, 2019 19:12
@RomainMuller
Copy link
Contributor

Hey @skorfmann -- thanks a lot for your contribution.

Would you be able to add some unit tests covering the new/fixed behavior?

@RomainMuller RomainMuller changed the title cloudfront distribution: pass viewerProtocolPolicy to behaviour fix(cloudfront): Pass viewerProtocolPolicy to the distribution's behaviors Mar 4, 2019
@RomainMuller RomainMuller self-assigned this Mar 4, 2019
@RomainMuller RomainMuller added the @aws-cdk/aws-cloudfront Related to Amazon CloudFront label Mar 4, 2019
@skorfmann
Copy link
Contributor Author

Would you be able to add some unit tests covering the new/fixed behavior?

Yes, will give it a shot later today

@skorfmann
Copy link
Contributor Author

Would you be able to add some unit tests covering the new/fixed behavior?

Added a unit test in 411c450

Side note: The contribution docs were quite helpful for getting the tests up and running 👍

@sam-goodwin
Copy link
Contributor

Thanks again for the fix! I'm curious if we should consider this a breaking change since it will change the (broken) behavior of any customer currently passing a non-default viewerProtocolPolicy value.

@sam-goodwin sam-goodwin merged commit 615ecd4 into aws:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront
Projects
None yet
Development

Successfully merging this pull request may close these issues.

viewerProtocolPolicy in aws-cloudfront does not seem to work
3 participants