Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(aws-ecs): add Fargate version 1.3.0 #1968

Merged
merged 1 commit into from
Mar 7, 2019

Conversation

robertd
Copy link
Contributor

@robertd robertd commented Mar 7, 2019

Added Fargate 1.3.0 enum and fixed 1.2 to 1.2.0 in docs for consistency.


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@robertd robertd requested review from SoManyHs and a team as code owners March 7, 2019 04:34
@rix0rrr
Copy link
Contributor

rix0rrr commented Mar 7, 2019

Is 1.3.0 now also the default? I think there are a couple more places you might need to update as well.

@rix0rrr rix0rrr self-requested a review March 7, 2019 07:41
@rix0rrr
Copy link
Contributor

rix0rrr commented Mar 7, 2019

Oh sorry, that was for EKS

@rix0rrr rix0rrr merged commit b529ad7 into aws:master Mar 7, 2019
@robertd robertd deleted the ecs-add-fargate-version branch March 7, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants