Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-ec2): All SSM WindowsVersion entries #1977

Merged
merged 1 commit into from
Mar 8, 2019
Merged

fix(aws-ec2): All SSM WindowsVersion entries #1977

merged 1 commit into from
Mar 8, 2019

Conversation

leepa
Copy link
Contributor

@leepa leepa commented Mar 8, 2019

Spurred on by Windows Server 2019 being missing as well as Windows
Server 2016 Full English Base I extracted the full list using the blog
post's example command to retreive them all and then filtered and
macroed it into this list.

The tests were using an invalid enum entry that pointed to a Parameter
Store entry which doesn't actually exist - fixed that too.


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Spurred on by Windows Server 2019 being missing as well as Windows
Server 2016 Full English Base I extracted the full list using the blog
post's example command to retreive them all and then filtered and
macroed it into this list.

The tests were using an invalid enum entry that pointed to a Parameter
Store entry which doesn't actually exist - fixed that too.
@leepa leepa requested a review from a team as a code owner March 8, 2019 10:01
@RomainMuller
Copy link
Contributor

Thank you so much!

@RomainMuller RomainMuller merged commit 85a1840 into aws:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants