feat(cloudformation): allow specifying additional inputs for deploy Actions #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n deploy Actions.
RomainMuller
approved these changes
Mar 15, 2019
eladb
reviewed
Mar 18, 2019
| * 'Param2': action2.outputArtifact.objectKey, | ||
| * } | ||
| * | ||
| * , if the output Artifacts of `action1` and `action2` were not used to |
There was a problem hiding this comment.
comma at the beginning of the sentence?
| * , if the output Artifacts of `action1` and `action2` were not used to | ||
| * set either the `templateConfiguration` or the `templatePath` properties, | ||
| * you need to make sure to include them in the `additionalInputArtifacts` - | ||
| * otherwise, you'll get an "unrecognized Artifact" error during your Pipeline's execution. |
There was a problem hiding this comment.
mention that artifacts can also be added using addInputArtifact
rix0rrr
pushed a commit
to alex-berger/aws-cdk
that referenced
this pull request
Mar 19, 2019
…ctions (aws#2020) Additional input Artifacts are needed when using the `parameterOverrides` property of the Action (any Artifact used in that map needs to be added to the input Artifacts of the Action, otherwise the Pipeline will fail at runtime). Also did some cleanup in the Action superclass while I was in the area. Fixes aws#1247
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional input Artifacts are needed when using the
parameterOverridesproperty of the Action (any Artifact used in that map needs to be added to the input Artifacts of the Action, otherwise the Pipeline will fail at runtime).Also did some cleanup in the Action superclass while I was in the area.
Fixes #1247
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.