Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cfnspec): update to version 2.28.0 #2035

Merged
merged 2 commits into from
Mar 18, 2019
Merged

feat(cfnspec): update to version 2.28.0 #2035

merged 2 commits into from
Mar 18, 2019

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Mar 18, 2019

Also in this commit:

  • Bugfix to the update script to compile, so create-new-libraries is
    actually run on the new spec.
  • Add 'npm run set-refkind' to make it easier to set refkinds for
    new resources.

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Also in this commit:

- Bugfix to the update script to compile, so create-new-libraries is
  actually run on the new spec.
- Add 'npm run set-refkind' to make it easier to set refkinds for
  new resources.
@rix0rrr rix0rrr requested a review from a team as a code owner March 18, 2019 12:57
@rix0rrr rix0rrr merged commit 6a671f2 into master Mar 18, 2019
@rix0rrr rix0rrr deleted the huijbers/cfn-update branch March 18, 2019 14:45
rix0rrr added a commit to alex-berger/aws-cdk that referenced this pull request Mar 19, 2019
Also in this commit:

- Bugfix to the update script to compile, so create-new-libraries is
  actually run on the new spec.
- Add 'npm run set-refkind' to make it easier to set refkinds for
  new resources.
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants