fix(autoscaling): require public subnets for associatePublicIpAddress #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AutoScalingGroup construct allows setting associatePublicIpAddress, but that is pointless when you're not in a Public subnet because your shiny public IP address will still not be routable. Adding the check get rids of another sharp edge around EC2 networking that people need to be aware of. Also change the 'isPublicSubnet()' method on VPC to work with subnet IDs instead of objects, to align better with the 'subnetIds()' function. BREAKING CHANGE: `VpcNetwork.isPublicSubnet()` has been renamed to `VpcNetwork.isPublicSubnetIds()`.
sam-goodwin
approved these changes
Mar 22, 2019
| */ | ||
| isPublicSubnet(subnet: IVpcSubnet): boolean; | ||
| isPublicSubnets(subnetIds: string[]): boolean; |
There was a problem hiding this comment.
not sure if idiomatic, but arePublicSubnets would be grammatically correct.
There was a problem hiding this comment.
Yeah, I know. But isXxx() is such a standard, didn't want to deviate from it.
How strongly do you feel about this?
| @@ -456,7 +456,7 @@ export class VpcNetwork extends VpcNetworkBase { | |||
| if (placement) { | |||
| const subnets = this.subnets(placement); | |||
| for (const sub of subnets) { | |||
| if (!this.isPublicSubnet(sub)) { | |||
| if (this.publicSubnets.indexOf(sub) === -1) { | |||
There was a problem hiding this comment.
Why not use the function you created?
There was a problem hiding this comment.
Because it feels silly to convert all subnet objects to IDs just to match on IDs.
I just realized it's a miracle this works at all, btw, because the subnet IDs are Tokens of course :).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AutoScalingGroup construct allows setting associatePublicIpAddress,
but that is pointless when you're not in a Public subnet because your
shiny public IP address will still not be routable.
Adding the check get rids of another sharp edge around EC2 networking
that people need to be aware of.
Also change the 'isPublicSubnet()' method on VPC to work with subnet IDs
instead of objects, to align better with the 'subnetIds()' function.
BREAKING CHANGE:
VpcNetwork.isPublicSubnet()has been renamed toVpcNetwork.isPublicSubnetIds().Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.