Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-apigateway): add integrationHttpMethod prop to AwsIntegration #2160

Merged
merged 1 commit into from
Apr 10, 2019

Conversation

unstubbable
Copy link
Contributor

Allows a custom http method to be used for an AWS integration, using POST as default.

Fixes #2105


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@unstubbable unstubbable requested a review from a team as a code owner April 2, 2019 14:12
Allows a custom http method to be used for an AWS integration, using POST as default.

Fixes aws#2105
@unstubbable
Copy link
Contributor Author

Is there something I should change in order for this to be considered?

Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry slipped under our radar. Looks good

@eladb eladb merged commit dfc6665 into aws:master Apr 10, 2019
@unstubbable unstubbable deleted the fix-integration-http-method branch April 10, 2019 10:06
@ranguard
Copy link
Contributor

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AwsIntegration integrationHttpMethod hard coded to: POST !
3 participants